[UI/#191] 공고 상세 뷰 / 2차 UI로 전면 수정 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
boiledEgg-s
approved these changes
Sep 2, 2024
| ), | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| modifier = modifier | ||
| .padding( |
There was a problem hiding this comment.
이 부분은 불필요한 것 같네요!!
그리고 왜 여기에 인자로 받은 modifier를 사용하신건가요??
Comment on lines
42
to
45
| horizontalArrangement = Arrangement.spacedBy( | ||
| 0.dp, | ||
| Alignment.CenterHorizontally | ||
| ), |
There was a problem hiding this comment.
Arrangement.Center로 대체 가능하지 않나요?
leeeyubin
approved these changes
Sep 4, 2024
Comment on lines
32
to
41
| Column( | ||
| modifier = Modifier | ||
| .fillMaxWidth(), | ||
| ) { | ||
| Row( | ||
| modifier = modifier | ||
| .background( | ||
| color = TerningSub3, | ||
| shape = RoundedCornerShape(size = 5.dp) | ||
| ), |
There was a problem hiding this comment.
매개변수로 전해준 modifier는 최상위인 Column에만 적용하는 게 좋을 것 같다는 생각이 드네요..!
Comment on lines
+52
to
+54
| modifier = Modifier.padding( | ||
| horizontal = 19.5.dp, | ||
| vertical = 1.5.dp |
There was a problem hiding this comment.
네엥..! 피그마대로 일단 반영해두었습니당 ㅠㅠㅠ
There was a problem hiding this comment.
파일 네이밍이 살짝 모호한 것 같은데 단순 view라면 어디서 쓰이는지 앞에 표시해주면 좋을 것 같아요!
There was a problem hiding this comment.
헉 조회수를 뜻하는 의미에서 view 라고 칭했는데 더 구체적으로 수정하겠ㅅ습니도
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
191.mp4
📢 To Reviewers